Match and fix all(?) SpriteOAM functions #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kermalis
reviewed
Dec 22, 2024
| } | ||
|
|
||
| // Hacky way of matching functions in menu_input.c AddMenuCursorSprite_, sub_801332C sub_8013470 | ||
| #define SpriteSetX_MatrixNumSize0(spritePtr, _x) \ |
There was a problem hiding this comment.
Probably can name this one like SetX (only x is set) and the other funcs can be like "ModifyMatrixNum", "ModifyX" etc (only the relevant bits are modified)
There was a problem hiding this comment.
Not a fan of this, because these names wouldn't be clear enough. Especially for someone who is not familiar with these, it may be confusing why there are two sets, and why SetX modifies also MatrixNum and X
Kermalis
reviewed
Dec 22, 2024
Kermalis
reviewed
Dec 22, 2024
Kermalis
reviewed
Dec 22, 2024
Kermalis
reviewed
Dec 22, 2024
|
Seems good |
SethBarberee
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's happened. All(or almost all) functions which were non-matching or using registers are finally matching, with easy to follow code.
Note that these have to be macros(which is not ideal, but nothing can be done about it I guess), for this particular case static inlines won't work.
What's interesting is these macros sometimes unroll to code like this
(&sp)->attribX &= ;which generates different asm(and in this case that's the matching asm) thansp.attribX &=.