Document VRAM transfer managers for sprite components #357
Conversation
| } | ||
| } | ||
|
|
||
| void *CharTransfer_PopTaskManager(void) |
There was a problem hiding this comment.
question: I'm only familiar with push/pop in the context of stacks - is this another way it's used? Without looking at these functions, I would be inclined to think it's a stack, unless I'm just unfamiliar with this usage of that terminology.
There was a problem hiding this comment.
Push/Pop can apply to any collection or concept where an underlying reference changes as a result of the operation. That definitely applies here (the private task manager changes pointer changes).
| break; | ||
| case GX_VRAM_OBJ_16_F: | ||
| case GX_VRAM_OBJ_16_G: | ||
| sTaskManager->vramSizeMain = 16 * 1024; |
There was a problem hiding this comment.
question: Is there a descriptive constant we can use for the 1024s here?
There was a problem hiding this comment.
It's just a kilobyte conversion. I don't think it's super worth a constant; this code is quite low-level, and I don't expect many users to ever look at it. 😅
This wound up being a bigger PR than I wanted it to be, but I felt like I should just document all of these related components in one fell swoop rather than leave any of them lingering.