Add ability to retrieve the sparks of a given server #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch merges
metroplex.spark
andmetroplex.sparks
intometroplex.servers
. This method now accepts an additional argument which can be a single spark id or an array of spark ids. If this argument is provided the method returns only the servers for the given spark id(s), otherwise it follows the old behavior. This is the new signature:The old
metroplex.sparks
now returns the spark ids for the given server. It's new signature is the following:See discussion in #6.
P.S. The
self
argument was not documented and not so useful IMHO. I would like to remove it if the are no objections.