Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribution links to each example description #425

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

calebfoss
Copy link
Contributor

I used the Github API to pull the blame for each example with Github username data. I then mapped that data to links and added them to the descriptions for each example. Finally, I made some manual tweaks based on contributors that were missing from the blame, such as @Malayvasa who contributed examples via p5 editor links.

@Qianqianye
Copy link
Collaborator

Thanks @calebfoss. I'm still waiting for some previous contributors' feedback on this issue, like how to properly credit the contributors who worked on p5.js examples prior to the STF project, especially based on the fact that lots of p5.js examples were directly ported from examples on Processing website.

Meanwhile, @SableRaf is looking into getting clarification on processing website repo license issue.

I will come back to this PR after get more response from other contributors.

@ksen0
Copy link
Contributor

ksen0 commented Jan 24, 2025

Hi @calebfoss ,

As part of considering #415, I’ve checked your attribution lists against the all_contributors list on the p5.js GitHub readme, and I see that the following contributors are not in the All Contributors list:

Darren Kessner https://github.com/dkessner
Animesh Sinha https://github.com/AnimeshSinha1309
Kathryn Lichlyter https://github.com/katlich112358
Greg Albers https://github.com/geealbers
Aaron Welles [undefined]
Marco Macarena https://github.com/macarena
Kristian Hamilton https://github.com/khamiltonuk
Keshav Gupta https://github.com/keshavg2
adil rabbani https://github.com/AdilRabbani
Ritesh Patil https://github.com/riteshsp2000
Gabriel Sroka https://github.com/gabrielsroka
Casey Conchinha https://github.com/kcconch
davidblitz https://github.com/davidblitz
crh82 https://github.com/crh82

All but one I can add using the bot in processing/p5.js#2309 (“add ___ for example”). The contributor without link I can add manually unless you have their GitHub @. (Edited to add: I just checked that it's possible to add a name only without a GitHub handle in my fork: https://github.com/ksen0/p5.js/)

For all contributors those that are already on the list, I can go through and ensure there’s an “example” emoji/contribution note:

Caleb Foss https://github.com/calebfoss
Jared Donovan https://github.com/jareddonovan
Suhas CV https://github.com/suhascv
Acha https://github.com/Acha0203
Malay Vasa https://github.com/Malayvasa
Christopher Coleman https://github.com/digitalcoleman
Berke Özgen https://github.com/berkeozgen08
Urvashi https://github.com/ihsavru
Prashant Gupta https://github.com/prashantgupta24
Austin Lee Slominski https://github.com/aceslowman
Dave Pagurek https://github.com/davepagurek
Aidan Nelson https://github.com/AidanNelson
Aatish Bhatia https://github.com/aatishb
Jithin KS https://github.com/JithinKS97
Cameron Yick https://github.com/hydrosquall
sm7515 https://github.com/sm7515

Please let me know if I should go ahead with adding the above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants