Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Lesson: Add analisis-redes-sociales-teatro-1 #3095

Merged
merged 26 commits into from
Nov 30, 2023
Merged

Conversation

jenniferisasi
Copy link
Contributor

@jenniferisasi jenniferisasi commented Nov 24, 2023

Please summarise the reason for your Pull Request here

Closes #3094

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

@anisa-hawes
Copy link
Contributor

Update: Jenn and I are coming back to this with fresh brains next week 🙂

- Update links to assets
- Minor adjustments to text (removing general links to the assets directory)
@jenniferisasi
Copy link
Contributor Author

Ah, @anisa-hawes I can't approve my own PR (of course). But I've checked the paragraph from which you took out the reference to the assets folder and it's all good to go!! THANKS!

@anisa-hawes
Copy link
Contributor

anisa-hawes commented Nov 30, 2023

Hola @jenniferisasi!

I can approve, but I have had another thought. Going forwards, I'd like us to aim to avoid any screenshots of tabular data so that we can improve the accessibility of our lessons. Rather, we should be replacing them with data tables formatted in Markdown (the ones I'd suggest replacing are figures 4., 5., 6., 7., 8.). The tables in this lesson are simple, so I've prepared these quickly.

If you agree, I'll slot these in and remove the figures (and the corresponding .png files in /images) in those places. There might be some tiny adjustments to the Spanish, so I'll share a link to my commit and you can check any changes I make.

id label atributo1 atributo2
1 Nodo1 --- ---
2 Nodo2 --- ---
3 Nodo3 --- ---
1 2 3 4 5 6
1 0 9 0 0 0 0
2 4 0 0 0 0 0
3 0 0 0 0 0 0
4 0 0 0 0 0 0
5 0 0 0 0 0 0
6 0 0 0 0 0 0
id label género función
1 Belisa Mejuer Dama
2 Finea Mejuer Criada
3 Celia Mejuer Dama
4 Lucinda Mejuer Dama
5 Fabia Mejuer Criada
6 Don Juan Hombre Galán
7 Tello Hombre Criado
8 Octavio Hombre Galán
9 Julio Hombre Criado
10 Conde Enrique Hombre Galán
11 Fernando Hombre Criado
Belisa Finea Celia Lucinda Fabia Don Juan Tello Octavio Julio Conde Enrique Fernando
Belisa
Finea
Celia
Lucinda
Fabia
Don Juan
Tello
Octavio
Julio
Conde Enrique
Fernando
Belisa Finea Celia Lucinda Fabia Don Juan Tello Octavio Julio Conde Enrique Fernando
Belisa 1
Finea 1
Celia
Lucinda
Fabia
Don Juan
Tello
Octavio
Julio
Conde Enrique
Fernando

@jenniferisasi
Copy link
Contributor Author

Super @anisa-hawes! No problem, I'll keep an eye on this PR :)

Replace screenshots of spreadsheets with Markdown format tabular data.
Delete screenshot (replaced with Markdown-format tabular data).
Delete screenshot (replaced with Markdown-format tabular data).
Delete screenshot (replaced with Markdown-format tabular data).
Delete screenshot (replaced with Markdown-format tabular data).
Delete screenshot (replaced with Markdown-format tabular data).
Add line break between tables and closing </div> tags for table-wrapper.
@anisa-hawes
Copy link
Contributor

Hello @jenniferisasi. I think the tables are good (my table-wrappers are working as expected now! 😅 We needed a line break before the closing </div> tags).

If you have a moment to review the edits here, you will note that the only line of Spanish I adjusted is line 355: 2412e50

@jenniferisasi
Copy link
Contributor Author

Line 355 looks good, @anisa-hawes!

@jenniferisasi jenniferisasi merged commit fe4fcc0 into gh-pages Nov 30, 2023
4 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3094 branch November 30, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New ES lesson: Análisis de redes sociales de personajes teatrales (Parte 1)
2 participants