-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Lesson: Add analisis-redes-sociales-teatro-1 #3095
Conversation
With bio for David Merino Recalde
- Update activity + topic
Adjust relative links in <div>, line 384
Delete directory
Upload assets directory
Delete directory
Upload images directory
Delete incorrectly named directory
Update: Jenn and I are coming back to this with fresh brains next week 🙂 |
- Update links to assets - Minor adjustments to text (removing general links to the assets directory)
Update links to assets.
Ah, @anisa-hawes I can't approve my own PR (of course). But I've checked the paragraph from which you took out the reference to the assets folder and it's all good to go!! THANKS! |
Hola @jenniferisasi! I can approve, but I have had another thought. Going forwards, I'd like us to aim to avoid any screenshots of tabular data so that we can improve the accessibility of our lessons. Rather, we should be replacing them with data tables formatted in Markdown (the ones I'd suggest replacing are figures 4., 5., 6., 7., 8.). The tables in this lesson are simple, so I've prepared these quickly. If you agree, I'll slot these in and remove the figures (and the corresponding
|
Super @anisa-hawes! No problem, I'll keep an eye on this PR :) |
Replace screenshots of spreadsheets with Markdown format tabular data.
Delete screenshot (replaced with Markdown-format tabular data).
Delete screenshot (replaced with Markdown-format tabular data).
Delete screenshot (replaced with Markdown-format tabular data).
Delete screenshot (replaced with Markdown-format tabular data).
Delete screenshot (replaced with Markdown-format tabular data).
Add line break between tables and closing </div> tags for table-wrapper.
Hello @jenniferisasi. I think the tables are good (my If you have a moment to review the edits here, you will note that the only line of Spanish I adjusted is line 355: 2412e50 |
Line 355 looks good, @anisa-hawes! |
Please summarise the reason for your Pull Request here
Closes #3094
Checklist
Closes #ISSUENUMBER
to your summary above