Merge pull request #3495 from projectblacklight/i3494-relevant-facet-…

…suggest Ensure that facet suggestions are relevant to the user's query
projectblacklight · Jan 27, 2025 · e5618b6 · e5618b6
2 parents 8ee533f + f3a53b5
commit e5618b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/javascript/blacklight-frontend/facet_suggest.js b/app/javascript/blacklight-frontend/facet_suggest.js
@@ -6,7 +6,7 @@ const FacetSuggest = async (e) => {
     const facetField = e.target.dataset.facetField;
     if (!facetField) { return; }
 
-    const urlToFetch = `/catalog/facet_suggest/${facetField}/${queryFragment}`
+    const urlToFetch = `/catalog/facet_suggest/${facetField}/${queryFragment}${window.location.search}`
     const response = await fetch(urlToFetch);
     if (response.ok) {
         const blob = await response.blob()

diff --git a/spec/features/facets_spec.rb b/spec/features/facets_spec.rb
@@ -110,5 +110,13 @@
       expect(page).to have_link 'Old age'
       expect(page).to have_css 'a.facet-select', count: 2
     end
+
+    it 'shows the user facet suggestions that are relevant to their q param', :js do
+      visit '/catalog/facet/subject_ssim?q=tibet&search_field=all_fields'
+      fill_in 'facet_suggest_subject_ssim', with: 'la'
+
+      expect(page).to have_link 'Tibetan language'
+      expect(page).to have_css 'a.facet-select', count: 1
+    end
   end
 end