Skip to content

Commit

Permalink
Merge pull request #309 from projectblacklight/fix_bl8_testapp_fixup
Browse files Browse the repository at this point in the history
Test App fixup for BL8 only needed prior to 8.7.0
  • Loading branch information
seanaery authored Jan 7, 2025
2 parents 1239284 + 98f3376 commit d6092b8
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions spec/test_app_templates/lib/generators/test_app_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@ def run_bl7_jsbundling_fixup
end

def run_bl8_jsbundling_fixup
# while it's named confusingly, the BL8 assets:propshaft generator has what we need
# for jsbundling, I think.
if File.exist?("package.json") && Blacklight::VERSION.split(".").first == "8"
# BL 8.7.0 doesn't seem to need anything, but BL8 before that the automatic BL
# install process doesn't do everything we need.
#
# By manually triggering the BL8 assets:propshaft generator, we can get what we need
# for jsbundling, even though it's named confusingly for that, it works in these
# versions.
if File.exist?("package.json") && Gem::Requirement.create("~> 8.0", "< 8.7.0").satisfied_by?(Gem::Version.new(Blacklight::VERSION))
generate "blacklight:assets:propshaft"
end
end
Expand Down

0 comments on commit d6092b8

Please sign in to comment.