Add more PromQL tests #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
juliusv
reviewed
May 17, 2022
| @@ -45,13 +45,22 @@ test_cases: | |||
| # TODO: Add tests for staleness support. | |||
| - query: 'demo_memory_usage_bytes' | |||
| - query: '{__name__="demo_memory_usage_bytes"}' | |||
| # Check for spacing. | |||
| - query: ' { __name__ = "demo_memory_usage_bytes" } ' | |||
There was a problem hiding this comment.
Maybe put this into the lower section where we have multiple matchers, and have spaces around the comma as well?
juliusv
reviewed
May 17, 2022
| - query: 'demo_memory_usage_bytes{type!="free"}' | ||
| - query: 'demo_memory_usage_bytes{instance=~"demo.promlabs.com:.*"}' | ||
| # Check for anchored regexes. | ||
| - query: 'demo_memory_usage_bytes{instance=~"demo.promlabs.com"}' |
There was a problem hiding this comment.
Now that I see it, probably for good measure we should escape the dots here and in the existing query above :)
|
Ping! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto roidelapluie@o11y.eu