Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading Explicit Congestion Notification (ECN) for ROCE on Sysfs #689

Closed
wants to merge 0 commits into from

Conversation

dasturiasArista
Copy link
Contributor

Nvidia/Mellanox expose ROCE ECN information on sysfs on the path
/sys/class/net/<interface>/ecn/<protocol>/

There are 2 protocols Reaction Point (rp) and Notification point (np)

For each of the protocols they have a list of attributes:
/sys/class/net/<interface>/ecn/<protocol>/params/<requested attribute>

Each protocol will also if ECN is enabled per priority (where X is the
priority):
/sys/class/net/<interface>/ecn/<protocol>/enable/X

This is documented here
https://docs.nvidia.com/networking/display/mlnxofedv571020/explicit+congestion+notification+(ecn)

The attributes are documented here:
https://enterprise-support.nvidia.com/s/article/dcqcn-parameters

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updating but LGTM in general

@dasturiasArista
Copy link
Contributor Author

Needs updating but LGTM in general

Thanks for the review! Happy to update whatever needs to be updated, but I'm not entirely clear what that is :). Are you referring to the commit history? Would it just the cleanest in that case to just create a new fork and PR?

@discordianfish
Copy link
Member

@dasturiasArista No need for a new PR, I'd just squash your commits, rebase and then (force) push this branch again.

@dasturiasArista
Copy link
Contributor Author

Hey sorry about this, but I was trying to update everything without creating a new PR, but looks like I did something and it closed out the PR. I created a new PR here: #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants