Dont check for temperatures in /thermal_zone where mode=disabled #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue
Fixes: prometheus/node_exporter#2980
Current behaviour
node_exporter
checks for the contents oftemp
file even whenmode
is disabled due to which in the case when temp file contains a non desired value thethermal_zone
collector fails and no longer gives its related metricsProposed solution
mode
is set to disabledTesting
github.com/prometheus/procfs
innode_exporter
go.mod
to local dev setup ofprocfs
and comparing the results in bothcc: @discordianfish