Support nested definitions in GetMessageClassesForFiles #20112
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_719854337
branch
from
a7132d5 to
86fde96
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_719854337
branch
from
86fde96 to
c50d93a
Compare
Otherwise downstream callers must explicitly fetch and generate message classes for nested definitions. (For example [here](foxglove/mcap#1321).) Example: ``` message NestedTypeMessage { message NestedType { string data = 1; } NestedType nested = 1; } ``` Currently `GetMessageClassesForFiles()` will only return `NestedTypeMessage`, but miss `NestedTypeMessage.NestedType` (and any arbitrary level of nested definitions). This is an unexpected deviation from the comment that says that it will find and resolve all dependencies. PiperOrigin-RevId: 719854337
copybara-service
bot
force-pushed
the
test_719854337
branch
from
c50d93a to
1f98b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support nested definitions in GetMessageClassesForFiles
Otherwise downstream callers must explicitly fetch and generate message classes for nested definitions. (For example here.)
Example:
Currently
GetMessageClassesForFiles()will only returnNestedTypeMessage, but missNestedTypeMessage.NestedType(and any arbitrary level of nested definitions).This is an unexpected deviation from the comment that says that it will find and resolve all dependencies.