Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter markets by known oracles #2100

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Filter markets by known oracles #2100

wants to merge 7 commits into from

Conversation

hexyls
Copy link
Contributor

@hexyls hexyls commented Jul 14, 2021 •
edited
Loading

closes #2099

Adds a $knownOracles query for the market list

I'm using a test rinkeby subgraph for this PR, after review we will need to deploy the subgraph to the protofire subgraph and update the graph url.

Testing:

  • On Rinkeby there should only be two markets listed in open markets:

Screen Shot 2021-08-06 at 10 58 45 am

@hexyls hexyls marked this pull request as draft July 14, 2021 05:51
@hexyls hexyls marked this pull request as ready for review August 6, 2021 00:55
@hexyls hexyls requested review from kadenzipfel and pimato August 6, 2021 00:58
@Frankaus Frankaus self-requested a review August 6, 2021 10:01
Frankaus
Frankaus approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@Frankaus Frankaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On Rinkeby there should only be two markets listed in open markets

Screenshot 2021-08-06 at 12 02 09

kadenzipfel
kadenzipfel approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@kadenzipfel kadenzipfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On Rinkeby there should only be two markets listed in open markets

lgtm!

@hexyls hexyls marked this pull request as draft August 12, 2021 05:41
@hexyls
Copy link
Contributor Author

hexyls commented Aug 12, 2021

In draft until we can test with production rinkeby/mainnet/xdai subgraphs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frankaus Frankaus Frankaus approved these changes

@kadenzipfel kadenzipfel kadenzipfel approved these changes

@pimato pimato Awaiting requested review from pimato

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter markets by known oracles
4 participants
@hexyls @kadenzipfel @Frankaus @pimato