Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub out new localization.md for names including pgf #43

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

nvkelso
Copy link
Collaborator

@nvkelso nvkelso commented Jun 27, 2024

@nvkelso nvkelso marked this pull request as draft June 27, 2024 21:53
@nvkelso
Copy link
Collaborator Author

nvkelso commented Jun 28, 2024

@wipfli can you take a pass at editing this, please? Maybe add some examples in the MapLibre section at the bottom, too? Thanks :)

basemaps/localization.md Outdated Show resolved Hide resolved
basemaps/localization.md Outdated Show resolved Hide resolved
@nvkelso
Copy link
Collaborator Author

nvkelso commented Jul 31, 2024

@wipfli Is this docs PR still useful? It may need to be updated for a few recent changes...

@wipfli
Copy link
Contributor

wipfli commented Aug 10, 2024

See #47 @nvkelso

@nvkelso
Copy link
Collaborator Author

nvkelso commented Aug 12, 2024

It looks like releases Tiles v3.7.0 added a positioned glyph font encoding for Devanagari (for Hindi) and Tiles v3.6.0 added pmap:script for non-latin names, so merging this PR would reflect production now instead of dev. The recent #47 addressed other review comments including using stable blog post URLs for some of the "see more" links.

I think the only blocker then for merging this PR is if we want to keep the sections for styling examples, which are currently empty stubs? @wipfli do you want to take a crack at that?

@wipfli
Copy link
Contributor

wipfli commented Aug 13, 2024

I would leave the document as it is right now and publish it. Once we have language localization in the TypeScript I can update the relevant sections in the document.

@bdon bdon marked this pull request as ready for review August 13, 2024 12:54
@bdon bdon merged commit e54d3dd into main Aug 16, 2024
1 check passed
@bdon
Copy link
Member

bdon commented Aug 16, 2024

Merging this first! Thanks.

@bdon bdon deleted the nvkelso/docs-localization-and-pgf branch August 16, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants