-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made "Back to top" button sticky #302
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @somenath1435, thanks for your changes...I guess margin-left
would push the button to the left side of the page because it is "inline" so you might not want to do it (float it to the right might work) and also, as the "sticky" button would overlap with the content on the page, can you offset it so that it doesn't block the content.
Thanks!
@Rishabh570 margin-left: auto will push the content to right. Now, I,ve shifted the button so that it is not overlapping with the contents. |
@jywarren @Rishabh570 please review the current changes |
@somenath1435 Can you please share a screenshot of changes? Thanks. |
@somenath1435 It's weird but the changes made here are not showing the same effect on my local version...can you re-confirm it by rebasing your branch and showing the GIF, please. |
@Rishabh570 Can I work on this. |
Hi @somenath1435, are you working on it? If not, @govindgoel can go ahead. Thanks! |
@govindgoel go ahead |
I guess we should close this pull request. |
I have commented on the issue #301 and willing to fix this cause it looks weird in the middle and needs to be fixed asap. |
fixes #301
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!