Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made "Back to top" button sticky #302

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Made "Back to top" button sticky #302

wants to merge 2 commits into from

Conversation

somenath1435
Copy link
Contributor

fixes #301
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

Copy link
Collaborator

@Rishabh570 Rishabh570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @somenath1435, thanks for your changes...I guess margin-left would push the button to the left side of the page because it is "inline" so you might not want to do it (float it to the right might work) and also, as the "sticky" button would overlap with the content on the page, can you offset it so that it doesn't block the content.
Thanks!

@somenath1435
Copy link
Contributor Author

@Rishabh570 margin-left: auto will push the content to right. Now, I,ve shifted the button so that it is not overlapping with the contents.

@somenath1435
Copy link
Contributor Author

@jywarren @Rishabh570 please review the current changes

@Rishabh570
Copy link
Collaborator

@somenath1435 Can you please share a screenshot of changes?

Thanks.

@somenath1435
Copy link
Contributor Author

Here is the screenshot:
Screenshot from 2020-01-24 10-01-33

@Rishabh570
Copy link
Collaborator

@somenath1435 It's weird but the changes made here are not showing the same effect on my local version...can you re-confirm it by rebasing your branch and showing the GIF, please.

@govindgoel
Copy link
Member

@Rishabh570 Can I work on this.

@Rishabh570
Copy link
Collaborator

Hi @somenath1435, are you working on it? If not, @govindgoel can go ahead.

Thanks!

@somenath1435
Copy link
Contributor Author

@govindgoel go ahead

@pydevsg
Copy link
Member

pydevsg commented Oct 1, 2020

I guess we should close this pull request.
What are your thoughts @somenath1435 , @Rishabh570 ?

@pydevsg
Copy link
Member

pydevsg commented Oct 1, 2020

I have commented on the issue #301 and willing to fix this cause it looks weird in the middle and needs to be fixed asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "Back To Top" button sticky
4 participants