Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): Update broken links in index.html page #577

Merged
merged 3 commits into from
May 17, 2022
Merged

(fix): Update broken links in index.html page #577

merged 3 commits into from
May 17, 2022

Conversation

YorhaBlue
Copy link
Contributor

@YorhaBlue YorhaBlue commented May 13, 2022 •
edited
Loading

Fixes #568 - Also put all changes from PRs #572, #573, #574 together into one PR.

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

This was referenced May 13, 2022
Closed
Closed
Closed
@YorhaBlue
Copy link
Contributor Author

@publiclab/revieweres done! All changes have been merged into one PR .

TildaDares
TildaDares approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful work @YorhaBlue. Thank you!!

@TildaDares TildaDares merged commit 541613f into publiclab:main May 17, 2022
@welcome
Copy link

welcome bot commented May 17, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@TildaDares
Copy link
Member

Congratulations @YorhaBlue 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TildaDares TildaDares TildaDares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update broken links in index.html page
2 participants
@YorhaBlue @TildaDares