Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zeitwerk to 2.6.18 #4545

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Upgrade zeitwerk to 2.6.18 #4545

merged 1 commit into from
Nov 6, 2024

Conversation

sandbergja
Copy link
Member

@sandbergja sandbergja commented Nov 6, 2024

This allows us to use Blacklight 8.6.1. On our current verions of zeitwerk, Blacklight 8.6.1 gives us an uninitialized constant Blacklight::Rendering (NameError) error when we try to start the application.

Many thanks to @cgalarza for your detective work on this issue!

Helps with #4539, since this will allow us to use 8.6.1, which includes a fix for this bug.

See also projectblacklight/blacklight#3431

This allows us to use Blacklight 8.6.1.  On our current verions of zeitwerk,
Blacklight 8.6.1 gives us an uninitialized constant Blacklight::Rendering (NameError)
error when we try to start the application.

Many thanks to @cgalarza for your detective work on this issue!

Helps with #4539, since this will allow us to use 8.6.1, which fixes this bug.

See also projectblacklight/blacklight#3431
Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja! 🍄

@maxkadel maxkadel merged commit b2fa625 into main Nov 6, 2024
14 checks passed
@maxkadel maxkadel deleted the zeitwerk-upgrade branch November 6, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants