Skip to content

Commit

Permalink
Do not ignore case on WIP
Browse files Browse the repository at this point in the history
You may legitimately want to use e.g. "fixup" in your commit message.
  • Loading branch information
mdellweg committed Jan 24, 2025
1 parent f332a34 commit 3ad0acc
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions templates/github/.ci/scripts/validate_commit_message.py.j2
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ BLOCKING_REGEX = [
r"^DO\s*NOT\s*MERGE",
r"^EXPERIMENT",
r"^FIXUP",
r"Apply suggestions from code review",
r"^fixup!", # This is created by 'git commit --fixup'
r"Apply suggestions from code review", # This usually comes from GitHub
]
try:
CHANGELOG_EXTS = [
Expand All @@ -35,7 +36,11 @@ message = subprocess.check_output(["git", "log", "--format=%B", "-n 1", sha]).de
if NOISSUE_MARKER in message:
sys.exit(f"Do not add '{NOISSUE_MARKER}' in the commit message.")

if any((re.match(pattern, message, re.IGNORECASE) for pattern in BLOCKING_REGEX)):
blocking_matches = [m for m in (re.match(pattern, message) for pattern in BLOCKING_REGEX) if m]
if blocking_matches:
print("Found these phrases in the commit message:")
for m in blocking_matches:
print(" - " + m.group(0))
sys.exit("This PR is not ready for consumption.")

g = Github(os.environ.get("GITHUB_TOKEN"))
Expand Down

0 comments on commit 3ad0acc

Please sign in to comment.