Cleanup #928
Merged
Cleanup #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
cleanup
branch
3 times, most recently
from
a14bb21 to
d3ef9b6
Compare
pedro-psb
requested changes
Nov 20, 2024
| # Rename "ci_update_branches" to "supported_release_branches" | ||
| if "ci_update_branches" in config: | ||
| config["supported_release_branches"] = config.pop("ci_update_branches") | ||
| write_new_config = True |
There was a problem hiding this comment.
This is one of these 'migrations' that happened long enough we can remove, right?
| if "exclude releasing.md" not in manifest_text: | ||
| manifest_file.write_text(manifest_text + "exclude releasing.md\n") | ||
| def migrate_dummy(plugin_root_dir): | ||
| pass |
There was a problem hiding this comment.
Is this a placeholder for when we have things to migrate?
A call for a migrations system, I hear? 😅
There was a problem hiding this comment.
exactly. We can also remove it and refer to the git history. What do you prefer?
| echo ::endgroup:: | ||
| - name: "Build package" | ||
| run: | | ||
| python3 setup.py sdist bdist_wheel --python-tag py3 | ||
| python3 -m build |
There was a problem hiding this comment.
I took that file from Pulpcore.
pedro-psb
reviewed
Nov 20, 2024
| return [] | ||
| except Exception: | ||
| # Gathering more details failed. | ||
| return ["pyproject.toml changed somehow (PLEASE check if dependencies are affected)."] |
There was a problem hiding this comment.
Maybe adding some info about the exception could be useful to know why gathering info failed
pedro-psb
reviewed
Nov 21, 2024
Also refactor it to not need templating.
pedro-psb
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.