(PUP-11754) Empty metadata files should be treated as though they don't exist #9012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaXLi
force-pushed
the
PUP-11754/Json.load_handles_empty_string
branch
2 times, most recently
from
4961dfa to
05ac75d
Compare
|
More work is definitely needed for this, I just wanted to lay down some groundwork for whoever picks this up |
|
Upstream issue filed in intridea/multi_json#206 |
AriaXLi
force-pushed
the
PUP-11754/Json.load_handles_empty_string
branch
3 times, most recently
from
3fb53ea to
3c472fa
Compare
AriaXLi
force-pushed
the
PUP-11754/Json.load_handles_empty_string
branch
2 times, most recently
from
f0e7761 to
af4b326
Compare
joshcooper
reviewed
Mar 9, 2023
AriaXLi
changed the title
joshcooper
reviewed
Mar 9, 2023
AriaXLi
force-pushed
the
PUP-11754/Json.load_handles_empty_string
branch
from
b2a126f to
d93b639
Compare
…'t exist
This commit treats empty metadata files as though they don't exist. This is
acheived by returning an empty hash '{}' when attempting to read an empty
metadata file which prevents Puppet::Util::Json.load() to be used on the empty
metadata files.
AriaXLi
force-pushed
the
PUP-11754/Json.load_handles_empty_string
branch
from
a450838 to
f2d0b4d
Compare
joshcooper
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has Puppet::Util::Json.load check if an empty string is passed in and returns nil if an empty string is passed in. More work may be necessary to ensure Puppet::Util::Json.load behaves as expected.