Code

Ptime mapper script#737

Code

Draft

RandomTannenbaum wants to merge 80 commits intomasterpuzzle/skills:masterfrom ptime-mapper-scriptpuzzle/skills:ptime-mapper-scriptCopy head branch name to clipboard

+798-155

Commits

Commits on Jun 21, 2024

• Create migration to add ptime id to person model

  RandomTannenbaum

  committed
  a77a77d

  Copy full SHA for a77a77d

• Start writing mapper script

  RandomTannenbaum

  committed
  665bf0b

  Copy full SHA for 665bf0b

Commits on Jun 24, 2024

• Implement basic PTime client class and install webmock gem

  ManuelMoeri

  committed
  2f1660f

  Copy full SHA for 2f1660f

• Create new migration to fix naming of ptime_emplyoee_id attribute

  ManuelMoeri

  committed
  0555ec7

  Copy full SHA for 0555ec7

• Add first test to see how webmock works

  ManuelMoeri

  committed
  83fa511

  Copy full SHA for 83fa511

• Fix first client spec

  RandomTannenbaum

  committed
  fbc8987

  Copy full SHA for fbc8987

Commits on Jun 25, 2024

• Write json body to test employee endpoint

  RandomTannenbaum

  committed
  6a75e33

  Copy full SHA for 6a75e33

• Fix tests by allowing localhost connection and write negative test for the ptime client

  RandomTannenbaum

  committed
  6a9a89a

  Copy full SHA for 6a9a89a

• Make ptime client specs not read values from env variables

  RandomTannenbaum

  committed
  9ddd723

  Copy full SHA for 9ddd723

• Set error messages on errors in client and change test data urls to example.com

  RandomTannenbaum

  committed
  7ab6727

  Copy full SHA for 7ab6727

• Fix params of ptime client and implement basic mapper script

  RandomTannenbaum

  committed
  8f85e91

  Copy full SHA for 8f85e91

• Add new tests and remove unnecessary

  RandomTannenbaum

  committed
  f945378

  Copy full SHA for f945378

Commits on Jun 26, 2024

• Add test for ambiguous matched people

  ManuelMoeri

  committed
  933c2fc

  Copy full SHA for 933c2fc

• Add email to filter before matching as well

  ManuelMoeri

  committed
  ff37bcc

  Copy full SHA for ff37bcc

• Possibly make rubocop happy

  ManuelMoeri

  committed
  244369f

  Copy full SHA for 244369f

• Try to make rubocop happy again

  ManuelMoeri

  committed
  7e58084

  Copy full SHA for 7e58084

Commits on Jun 27, 2024

• Add evaluate task for mapping script

  RandomTannenbaum

  committed
  132424a

  Copy full SHA for 132424a

• Outsource mapper script code to methods and fix tests

  RandomTannenbaum

  committed
  2070ffb

  Copy full SHA for 2070ffb

• Add test for dry run

  RandomTannenbaum

  committed
  b89c933

  Copy full SHA for b89c933

• Make rubocop happy :)

  RandomTannenbaum

  committed
  b44a2d0

  Copy full SHA for b44a2d0

• Remove unnecessary requires

  RandomTannenbaum

  committed
  f9be66c

  Copy full SHA for f9be66c

• Replace .count == 1 with .one?

  RandomTannenbaum

  committed
  104185e

  Copy full SHA for 104185e

• Start writing script that updates the data of the people in skills

  RandomTannenbaum

  committed
  aa4c5f5

  Copy full SHA for aa4c5f5

Commits on Jun 28, 2024

• Write script that maps the data from a ptime employee to the corresponding skills person

  RandomTannenbaum

  committed
  7d775c3

  Copy full SHA for 7d775c3

• Disable rubocop metrics all together instead of one by one in assign employee id and update people data scripts

  RandomTannenbaum

  committed
  82d03f0

  Copy full SHA for 82d03f0

• Fix file naming of spec files

  RandomTannenbaum

  committed
  96913d2

  Copy full SHA for 96913d2

• Move class into module and fix mapping of person to employee data, write specs to test mapping of people data

  RandomTannenbaum

  committed
  907da90

  Copy full SHA for 907da90

• Fix updating of people data and test it and fix faulty key in json used for testing requests

  RandomTannenbaum

  committed
  35f4b0d

  Copy full SHA for 35f4b0d

• Fix update people data specs by assigning the ptime base url env var in before each

  RandomTannenbaum

  committed
  1190569

  Copy full SHA for 1190569

• Only update ptime employee id if its not already set

  RandomTannenbaum

  committed
  5ac5585

  Copy full SHA for 5ac5585

• Test if marital status can be changed in specs

  RandomTannenbaum

  committed
  8c8e0e4

  Copy full SHA for 8c8e0e4

• Write rake task that runs the people update

  RandomTannenbaum

  committed
  dd0bacd

  Copy full SHA for dd0bacd

• Show message in assign employee ids script conditionally

  RandomTannenbaum

  committed
  b2d5d0b

  Copy full SHA for b2d5d0b

Commits on Jul 1, 2024

• Add delayed jobs and daemon gems and start writing delayed jobs

  RandomTannenbaum

  committed
  dbe7132

  Copy full SHA for dbe7132

Commits on Jul 2, 2024

• Fix specs to work with delayed job

  RandomTannenbaum

  committed
  6fb4df1

  Copy full SHA for 6fb4df1

Commits on Jul 3, 2024

• Remove delayed job functionality

  RandomTannenbaum

  committed
  480e328

  Copy full SHA for 480e328

Commits on Jul 4, 2024

• Add first approach for fetching people from ptime API

  ManuelMoeri

  committed
  138fab7

  Copy full SHA for 138fab7

• Add helper and write test for fetching employee data

  ManuelMoeri

  committed
  7f6abdd

  Copy full SHA for 7f6abdd

Commits on Jul 5, 2024

• Finish test and fix logic in displaying people

  ManuelMoeri

  committed
  ea3d4e5

  Copy full SHA for ea3d4e5

• Implement correct routing of person and fix a problem in the docker setup with yminder

  ManuelMoeri

  committed
  3a6b7c0

  Copy full SHA for 3a6b7c0

Commits on Jul 8, 2024

• Possibly fix docker compose file

  ManuelMoeri

  committed
  c25e18c

  Copy full SHA for c25e18c

• Fix tests and implement logic for sorting people

  ManuelMoeri

  committed
  4385c4a

  Copy full SHA for 4385c4a

Commits on Jul 9, 2024

• Implement logic for fallback and cleanup helper method

  ManuelMoeri

  committed
  202006a

  Copy full SHA for 202006a

• Improve fallback logic by making it more readable and shorter

  ManuelMoeri

  committed
  1dc3065

  Copy full SHA for 1dc3065

Commits on Jul 10, 2024

• Implement first approach on calling the ptime api after 5 minutes

  ManuelMoeri

  committed
  1267736

  Copy full SHA for 1267736

Commits on Jul 11, 2024

• Improve logic of 5 minutes request and change client.rb

  ManuelMoeri

  committed
  512593b

  Copy full SHA for 512593b

Commits on Jul 12, 2024

• Add logic to load site correctly and remove unnecessary code

  ManuelMoeri

  committed
  c9e9825

  Copy full SHA for c9e9825

Commits on Jul 15, 2024

• Fix logic of rendering people and cleanup code

  ManuelMoeri

  committed
  39acf6e

  Copy full SHA for 39acf6e

Commits on Jul 17, 2024

• Add tests for person_helper

  ManuelMoeri

  committed
  d967660

  Copy full SHA for d967660

• Add ptime_helpers to cleanup code

  ManuelMoeri

  committed
  c657e8f

  Copy full SHA for c657e8f

• Fix tests

  ManuelMoeri

  committed
  bcb3ebe

  Copy full SHA for bcb3ebe

• Fix last test and remove pry

  ManuelMoeri

  committed
  456f27b

  Copy full SHA for 456f27b

Commits on Jul 18, 2024

• Fix test and add comment

  ManuelMoeri

  committed
  4718e92

  Copy full SHA for 4718e92

• Generalize window resizing of capybara

  ManuelMoeri

  committed
  bf771aa

  Copy full SHA for bf771aa

Commits on Jul 19, 2024

• Cleanup code and add comments

  ManuelMoeri

  committed
  189ab80

  Copy full SHA for 189ab80

• Add one more test for client.rb

  ManuelMoeri

  committed
  2e2ae6b

  Copy full SHA for 2e2ae6b

• Reverse test from last commit

  ManuelMoeri

  committed
  766e942

  Copy full SHA for 766e942

Commits on Jul 25, 2024

• change location of helper

  kcinay055679

  committed
  aa36e82

  Copy full SHA for aa36e82

• set ptime stubing global

  kcinay055679

  committed
  4153a5b

  Copy full SHA for 4153a5b

• clean up ptime client specs

  kcinay055679

  committed
  87d84d8

  Copy full SHA for 87d84d8

• create json file for fixtures

  kcinay055679

  committed
  96391b2

  Copy full SHA for 96391b2

• use hashes instead of strings for json keys create global ptime stub method

  kcinay055679

  committed
  cce291b

  Copy full SHA for cce291b

• use custom ptime stubbing method everywhere

  kcinay055679

  committed
  d3bb9c3

  Copy full SHA for d3bb9c3

• fix tests after always using [:data]

  kcinay055679

  committed
  dd96900

  Copy full SHA for dd96900

• clean up ptime client

  kcinay055679

  committed
  0d1c4ff

  Copy full SHA for 0d1c4ff

• improve structure of people search

  kcinay055679

  committed
  7550234

  Copy full SHA for 7550234

• Client isn't longer controlled by random env vars

  kcinay055679

  committed
  552cf7d

  Copy full SHA for 552cf7d

• simplify ptime_helpers

  kcinay055679

  committed
  d9c02be

  Copy full SHA for d9c02be

Commits on Jul 26, 2024

• clean up PR

  kcinay055679

  committed
  44d76bd

  Copy full SHA for 44d76bd

• Clean up Skills db fallback logic

  kcinay055679

  committed
  71db98a

  Copy full SHA for 71db98a

• improve readability by using more helper

  kcinay055679

  committed
  3a7997a

  Copy full SHA for 3a7997a

• clean up

  kcinay055679

  committed
  d19bd8e

  Copy full SHA for d19bd8e

Commits on Jul 29, 2024

• add client test

  kcinay055679

  committed
  57ad58a

  Copy full SHA for 57ad58a

• Merge pull request #748 from puzzle/feature/745-fetch-people-search-entries-from-ptime

  Show description for 5411381
  kcinay055679

  authored
  5411381

  Copy full SHA for 5411381

• ds muäs so

  kcinay055679

  committed
  af3def7

  Copy full SHA for af3def7

• so its aber

  kcinay055679

  committed
  2763d61

  Copy full SHA for 2763d61

• Resolve conversations

  RandomTannenbaum

  committed
  d272a03

  Copy full SHA for d272a03

Commits on Jul 30, 2024

• Remove unneeded spec and fix spec that tests the not found case when mapping

  RandomTannenbaum

  committed
  48fb6be

  Copy full SHA for 48fb6be

• Fix order of name interpolation in id mapper script

  RandomTannenbaum

  committed
  a52ceaa

  Copy full SHA for a52ceaa

• Update json fixtures and use full_name instead of interpolating it

  RandomTannenbaum

  committed
  65fb684

  Copy full SHA for 65fb684