Skip to content

Commit

Permalink
fix(): temp fix for packaging as we work through backend issues (#4852)
Browse files Browse the repository at this point in the history
fixes #[issue number] 
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

 Bugfix 


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->
Due to an issue in our backend, the packaging process has some issues
currently, which we need to fix our deployments to fix. Because of this,
the quicker fix is to get a temp front-end fix in.

## Describe the new behavior
This will not enable widgets if the app does not actually implement
widgets, BUT, by setting this flag, we avoid the broken code on our
backend.

## PR Checklist

- [x ] Test: run `npm run test` and ensure that all tests pass
- [ x] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ x] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information
  • Loading branch information
jgw96 authored Jan 8, 2025
1 parent 3a83582 commit 8749a0d
Showing 1 changed file with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,15 @@ export async function generateWindowsPackage(
}
}

// temp fix for packaging problem
if (!windowsOptions.enableWebAppWidgets) {
windowsOptions.enableWebAppWidgets = true;
}

if (!windowsOptions.manifestUrl || windowsOptions.manifestUrl.length === 0) {
windowsOptions.manifestUrl = await getManifestUrl();
}

const validationErrors = validateWindowsOptions(windowsOptions);
if (validationErrors.length > 0 || !windowsOptions) {
throw new Error(
Expand Down

0 comments on commit 8749a0d

Please sign in to comment.