attempt to fix tox on bcrypt CI #953
Conversation
ngoldbaum
force-pushed
the
fix-tox-gha
branch
from
82fdbf4 to
cf07080
Compare
|
looks like maybe tox.ini needs to be updated? |
ngoldbaum
force-pushed
the
fix-tox-gha
branch
from
cf07080 to
e0c48f4
Compare
I think tox might need an update too now that virtualenv knows about |
ngoldbaum
force-pushed
the
fix-tox-gha
branch
from
e0c48f4 to
8ab5f48
Compare
That seems to have fixed it. I looked through a few of the jobs and it seems to be discovering the correct python just by finding the first one in $PATH. |
.github/workflows/ci.yml
Outdated
| - {VERSION: "3.8", TOXENV: "py38"} | ||
| - {VERSION: "3.13", TOXENV: "py313"} | ||
| - {VERSION: "3.13t", TOXENV: "py313"} | ||
| - {VERSION: "3.13t", TOXENV: "py313t"} |
There was a problem hiding this comment.
These TOXENVs aren't used anymore, right?
| env: | ||
| TOXENV: ${{ matrix.PYTHON.TOXENV }} |
There was a problem hiding this comment.
but without this, the toxenv for mypy, pep8, packaging isn't respected :-/
There was a problem hiding this comment.
Ugh, sorry for all the back-and-forth. Should be fixed now, I think.
I also noticed that the information about these environments wasn't showing up in the actions environment name - so I added it back.
ngoldbaum
force-pushed
the
fix-tox-gha
branch
from
99792f2 to
236a006
Compare
|
FYI, I got annoyed enough that I submitted #954 to switch us to nox. Thanks for poking and debugging this! But assuming nox works, I think that's probably a better direction for us. |
Fair enough - feel free to merge this if that turns out to have issues. Doesn't look like it though. |
|
Thanks so much for your continued contributions! What rotten luck that this broke the day after it was merged :-) |
No description provided.