Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests into scripts #832

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Jan 9, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

@hameerabbasi hameerabbasi force-pushed the refactor-test-ci-contrib branch 6 times, most recently from d7d1a34 to 9a82cb2 Compare January 9, 2025 11:10
@hameerabbasi
Copy link
Collaborator Author

@willow-ahrens Instead of listing out a big ol' set of commands I refactored the CI out into scripts, and made scripts to call all those and set up the env as well.

Comment on lines +80 to +89
### Advanced

To run the complete set of unit tests run in CI for your platform, run the following
in the repository root:

```bash
ci/setup_env.sh
ACTIVATE_VENV=1 ci/test_all.sh
```

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the main commands you'd need to follow assuming a sane Python installation.

Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #832 will improve performances by 13.07%

Comparing refactor-test-ci-contrib (bb8b571) with main (ada7871)

Summary

⚑ 1 improvements
βœ… 339 untouched benchmarks

Benchmarks breakdown

Benchmark main refactor-test-ci-contrib Change
⚑ test_index_fancy[side=100-rank=1-format='coo'] 1.4 ms 1.2 ms +13.07%

Copy link
Collaborator

@mtsokol mtsokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants