Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the push method when the limit parameter is bigger than the chunk… #9940

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Fix the push method when the limit parameter is bigger than the chunk… #9940

merged 7 commits into from
Jan 29, 2025

Conversation

josephnowak
Copy link
Contributor

@josephnowak josephnowak commented Jan 11, 2025 •
edited
Loading

@dcherian
Copy link
Contributor

Yeah the issue is that we "scan" the "auxiliary sums" too with binop where we just want those to be concatenated. I think this suggests that we add a kwarg to dask.array.cumreduction. I added some ugly stuff to flox for this: https://github.com/xarray-contrib/flox/blob/ac319cc2edc77bb4932eca0b513becbc8a51cd6d/flox/aggregations.py#L677

@dcherian dcherian enabled auto-merge (squash) January 29, 2025 18:03
@dcherian dcherian merged commit d7ac79a into pydata:main Jan 29, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push method with limit bigger than the chunksize of Dask array is not correctly working
2 participants
@josephnowak @dcherian