This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Add support for async files as request body #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
commented
May 10, 2020
|
|
||
|
|
||
| # XX this should return an async iterator | ||
| def _request_bytes_iterable(request, state_machine): | ||
| """ | ||
| An iterable that serialises a set of bytes for the body. | ||
| """ | ||
|
|
||
| def all_pieces_iter(): |
There was a problem hiding this comment.
I'm not super happy with this function, there's probably a simpler way to do this rather than a direct translation.
There was a problem hiding this comment.
Possibly. Maybe @njsmith know how to improve this? In any case, this isn't blocking, so I'll merge this pull request.
sethmlarson
commented
May 10, 2020
sethmlarson
force-pushed
the
async-request-data
branch
2 times, most recently
from
69b3aab to
1d379e9
Compare
sethmlarson
force-pushed
the
async-request-data
branch
from
1d379e9 to
7f6bd7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
- Coverage 99.15% 98.79% -0.37%
==========================================
Files 21 22 +1
Lines 3196 3234 +38
==========================================
+ Hits 3169 3195 +26
- Misses 27 39 +12
|
pquentin
approved these changes
May 11, 2020
|
|
||
|
|
||
| # XX this should return an async iterator | ||
| def _request_bytes_iterable(request, state_machine): | ||
| """ | ||
| An iterable that serialises a set of bytes for the body. | ||
| """ | ||
|
|
||
| def all_pieces_iter(): |
There was a problem hiding this comment.
Possibly. Maybe @njsmith know how to improve this? In any case, this isn't blocking, so I'll merge this pull request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support async files like
trio.wrap_file(open())andanyio.aopen()and does some refactoring that will allow us to accept other async iterables as data sources easily.set_file_position()andrewind_body()able to handle async filesunasync.pyfile tohip.utilfor small unasync-related utilities likeanext()andawait_if_coro(). See Provide common replacement utils / functions many projects will need unasync#65 for more info here too.read_timeouttoAnyIOSocket.receive_some(), don't know how that bug wasn't caught earlier.body=.test/with_dummyserver/async/.test/with_dummyserver/async_only/for test cases that shouldn't be unasync-ed, things specific to an async library