Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove paragraph mentioning minor edits through the mailing list #1891

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Dec 2, 2024

No description provided.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Question for the typing council: Should we maybe remove the whole paragraph? To me, this sounds more like "PEPy" sentence than a "specy" one, i.e. it's clear that the spec can be amended as needed, this doesn't really need to be mentioned here.

@erictraut
Copy link
Collaborator

I agree that this whole paragraph should be removed. It probably should have been eliminated when copying the PEP contents into the spec. I think that was my oversight.

@JelleZijlstra
Copy link
Member

Yes, let's remove the whole paragraph. The statement in the paragraph is true for the whole spec: minor changes can be done through Typing Council action.

@Viicos
Copy link
Contributor Author

Viicos commented Dec 2, 2024

Done 👍

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't think this needs to go through the formal Typing Council decision process, but cc @carljm @JukkaL @rchen152 if you disagree.

@Viicos Viicos changed the title Change reference to now closed typing mailing list Remove paragraph mentioning minor edits through the mailing list Dec 2, 2024
@srittau srittau merged commit d1e4add into python:main Dec 5, 2024
4 checks passed
carljm added a commit to erictraut/typing that referenced this pull request Jan 9, 2025
* main: (29 commits)
  Updated conformance test results for the latest versions of type chec… (python#1904)
  Add content from typeshed/CONTRIBUTING.md (python#1882)
  Fix markup in generics specification (python#1900)
  Specs clarification: Forbid `ClassVar` and `Final` within `TypedDict` body (python#1890)
  Remove paragraph mentioning minor edits through the mailing list (python#1891)
  Writing Stubs: Add "Overloads and Flags" section (python#1894)
  Fix a typo (python#1893)
  Update conformance tests for recent generics spec change (python#1892)
  Clarify some behavior around user-defined generic classes (python#1879)
  Modernizing guide: Mention TypeGuard/TypeIs (python#1887)
  Tools can perform "some" refactorings (python#1886)
  Mention use of cast in enum type stub example (python#1877)
  Update conformance results after new pyre release (python#1878)
  Add a label for typed dictionaries class-based syntax (python#1873)
  Add missing return type to generic_syntax_infer_variance.py (python#1871)
  Updated conformance results for mypy 1.13 and pyright 1.1.386 (python#1870)
  Modernizing guide: also mention `com2ann` (python#1869)
  Suggest `pyupgrade` or `ruff` for modernizing superseded typing features (python#1868)
  Updated conformance results for pyright 1.1.385. (python#1867)
  Updated conformance results for mypy 1.12. (python#1866)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants