Update nonlinear_constraint_is_feasible to return a boolean tensor #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69209007 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 203 203
Lines 18671 18670 -1
=======================================
- Hits 18670 18669 -1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
…ytorch#2731) Summary: `nonlinear_constraint_is_feasible` checks whether the constraint is feasible for the given (batch of) candidates. Previously, this returned a boolean, which was False if any element of the batch was infeasible. This diff updates it to return a boolean tensor that shows whether each batch is feasible. Use cases are updated to comply with the new behavior. I'll utilize this in a follow up diff to introduce a helper that evaluates the feasibility of all forms of constraints. Reviewed By: dme65 Differential Revision: D69209007
saitcakmak
force-pushed
the
export-D69209007
branch
from
250b262 to
f3c63e4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69209007 |
|
This pull request has been merged in a43bd4d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
nonlinear_constraint_is_feasiblechecks whether the constraint is feasible for the given (batch of) candidates. Previously, this returned a boolean, which was False if any element of the batch was infeasible. This diff updates it to return a boolean tensor that shows whether each batch is feasible. Use cases are updated to comply with the new behavior.I'll utilize this in a follow up diff to introduce a helper that evaluates the feasibility of all forms of constraints.
Differential Revision: D69209007