Temporary PR for Code Sharing - Fix for set/get_extra_info and global_modread #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingyi-yan
reviewed
Sep 15, 2023
| @@ -67,10 +67,10 @@ Type Processing | |||
| enter_block("NEW"); | |||
| foreach p = CODE.TypeInfo#(t=_,v=_,_) \in params do | |||
| XFORM.insert_typeInfo(t,v); | |||
| enddo; | |||
| return FunctionDecl[symtab=exit_block()]#(name,params,ret,body); | |||
| enddo | |||
There was a problem hiding this comment.
Split your PR to commit one thing at a time. There is no call for you to change ExpStmt.incl. Your change for collect_mod is wrong. Your fix for get/set extra info is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a temporary PR to share code that addressed the following