Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of delete_multi method #125

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mikgry
Copy link

@mikgry mikgry commented Jan 8, 2024

I noticed that the delete_multi method is slow and makes n queries - It would be faster to delete multiple records with a single query.

@djmb
Copy link
Collaborator

djmb commented Jan 9, 2024

Looks great thanks @mikgry!

@djmb djmb merged commit 2dfb73f into rails:main Jan 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants