Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Run full installation by default (not just migrations) #190

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

philipithomas
Copy link
Contributor

@philipithomas philipithomas commented Aug 2, 2024

The current README command only add the migrations, not the config files.

But, two lines later in the same file, the docs reference Configuration will be read from config/solid_cache.yml - but, that file doesn't exist according to the current installation instructions.

I think this approach is cleaner, especially so that changes in defaults on version upgrades don't cause weird issues in the future.

Update: I refactored to match the docs style of the solid_queue docs, which defaults to the full installation by default but explains a more manual approach.

@djmb djmb merged commit c539d60 into rails:main Aug 12, 2024
37 checks passed
@philipithomas philipithomas deleted the patch-1 branch August 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants