Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'quiet: true' in condarc #217

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 9, 2024

See rapidsai/build-planning#126.

We are getting lots and lots of noisy log lines with no content, because progress bars are being included in our CI log lines. This sets quiet: true for conda to help with the problem.

@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Dec 9, 2024
@bdice
Copy link
Contributor Author

bdice commented Dec 9, 2024

We should probably wait until after the 24.12 release to merge this. Marking as do-not-merge.

@bdice bdice marked this pull request as ready for review December 9, 2024 23:36
@bdice bdice requested a review from a team as a code owner December 9, 2024 23:36
@bdice bdice requested review from msarahan and removed request for a team December 9, 2024 23:36
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so you can merge when you're ready, but yes I agree on not merging until 24.12 is done.

@bdice bdice removed the DO NOT MERGE Hold off on merging; see PR for details label Dec 16, 2024
@bdice bdice merged commit b26d564 into rapidsai:main Dec 16, 2024
407 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Some jobs failed on main so have restarted them

@jameslamb
Copy link
Member

Because this got reverted in #220, those excessive log lines from conda are still there and annoying folks: rapidsai/cuml#6224 (comment)

I put up a new issue to track that: #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants