Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom connection validation to ConnectionPoolSupport #3081 #3138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add custom connection validation to ConnectionPoolSupport #3081 #3138

wants to merge 1 commit into from

Conversation

big-cir
Copy link

@big-cir big-cir commented Jan 23, 2025

Overview

  • Introduce Predicate for connection validation
  • Add new overload to ConnectionPoolSupport.createGenericObjectPool()
  • Implement ConnectionPoolConfig to encapsulate validation and wrapping options
  • Update RedisPooledObjectFactory to use custom validation logic

Related Issues

#3081

@tishun
Copy link
Collaborator

tishun commented Feb 3, 2025

Hey @big-cir ,

did you try running mvn formatter:format?

@tishun tishun added the type: feature A new feature label Feb 3, 2025
@tishun tishun added this to the 6.6.0.RELEASE milestone Feb 3, 2025
@big-cir big-cir force-pushed the lettuce-connection-validation branch from e2fe8a1 to 11b8752 Compare February 3, 2025 08:38
@big-cir
Copy link
Author

big-cir commented Feb 3, 2025

@tishun
thanks :)
I tried running mvn formatter:format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.6.0.RELEASE
Development

Successfully merging this pull request may close these issues.
2 participants
@big-cir @tishun