Fix SimpleBatcher apparent deadlock #2196 #3148
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Flush Operation Conflict:
- When one thread (T1) performs a flush, it may read and dispatch batched commands before resetting the
flushing
flag.- If another thread (T2) adds a command and forced flush at this moment. Command might be added to the queue but does not trigger a flush.
- As a result, the command remains in the queue until the next flush request, causing a delay in dispatching.
Flag Reset Between Iterations:
- During a default flush operation, if multiple batches are processed, the
flushing
flag is reset between iterations.- This allows another thread to take over, potentially causing the initial thread to return
BatchTasks.EMPTY
instead of properly processed commands.Fix:
If force flush is requested while flushing, perform additional flush iteration after ongoing completes
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.