fix(cli-helpers): Don't add spaces around = for env vars (#11414)

redwoodjs · Sep 2, 2024 · 4c7199d · 4c7199d
1 parent 04a0050
commit 4c7199d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.changesets/11414.md b/.changesets/11414.md
@@ -0,0 +1,3 @@
+- fix(cli-helpers): Don't add spaces around `=` for env vars (#11414) by @Tobbe
+
+The `addEnvVar` helper function in `packages/cli-helpers` no longer adds spaces around `=` when setting environment variables.
diff --git a/packages/cli-helpers/src/lib/__tests__/__snapshots__/project.test.ts.snap b/packages/cli-helpers/src/lib/__tests__/__snapshots__/project.test.ts.snap
@@ -6,7 +6,7 @@ exports[`addEnvVar > addEnvVar adds environment variables as part of a setup tas
 
 # Note: The existing environment variable EXISTING_VAR was not overwritten. Uncomment to use its new value.
 # Updated existing variable Comment
-# EXISTING_VAR = new_value
+# EXISTING_VAR=new_value
 "
 `;
 
@@ -15,7 +15,7 @@ exports[`addEnvVar > addEnvVar adds environment variables as part of a setup tas
 # CommentedVar = 123
 
 # New Variable Comment
-NEW_VAR = new_value
+NEW_VAR=new_value
 "
 `;
 
@@ -24,7 +24,7 @@ exports[`addEnvVar > addEnvVar adds environment variables as part of a setup tas
 # CommentedVar = 123
 
 # New Variable Comment
-NEW_VAR = new_value
+NEW_VAR=new_value
 "
 `;
 
@@ -34,7 +34,7 @@ exports[`addEnvVar > addEnvVar adds environment variables as part of a setup tas
 
 # Note: The existing environment variable EXISTING_VAR was not overwritten. Uncomment to use its new value.
 # New Variable Comment
-# EXISTING_VAR = new_value
+# EXISTING_VAR=new_value
 "
 `;
 

diff --git a/packages/cli-helpers/src/lib/project.ts b/packages/cli-helpers/src/lib/project.ts
@@ -126,7 +126,7 @@ export const addEnvVar = (name: string, value: string, comment: string) => {
   let envFile = ''
   const newEnvironmentVariable = [
     comment && `# ${comment}`,
-    `${name} = ${value}`,
+    `${name}=${value}`,
     '',
   ]
     .flat()
@@ -144,7 +144,7 @@ export const addEnvVar = (name: string, value: string, comment: string) => {
       const p = [
         `# Note: The existing environment variable ${name} was not overwritten. Uncomment to use its new value.`,
         comment && `# ${comment}`,
-        `# ${name} = ${value}`,
+        `# ${name}=${value}`,
         '',
       ]
         .flat()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		- fix(cli-helpers): Don't add spaces around `=` for env vars (#11414) by @Tobbe

		The `addEnvVar` helper function in `packages/cli-helpers` no longer adds spaces around `=` when setting environment variables.