Fix form url

renuo · Nov 5, 2024 · c25374b · c25374b
1 parent 625a379
commit c25374b
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 12 deletions.
diff --git a/app/controllers/hotsheet/pages_controller.rb b/app/controllers/hotsheet/pages_controller.rb
@@ -23,7 +23,7 @@ def update # rubocop:disable Metrics/AbcSize
                                             errors: record.errors.full_messages.join(", "))
       end
 
-      redirect_to hotsheet_model_path(model)
+      redirect_to "#{root_path}#{model.table_name}"
     end
 
     private
@@ -33,7 +33,7 @@ def broadcast_params
     end
 
     def model_params
-      params.require(model.name.underscore.to_sym).permit(*model.editable_attributes)
+      params.require(model.name.underscore).permit(*model.editable_attributes)
     end
 
     def model

diff --git a/app/helpers/hotsheet/application_helper.rb b/app/helpers/hotsheet/application_helper.rb
@@ -3,9 +3,5 @@
 module Hotsheet
   module ApplicationHelper
     include Pagy::Frontend
-
-    def hotsheet_model_path(model)
-      "#{root_path}#{model.table_name}"
-    end
   end
 end
diff --git a/app/views/hotsheet/pages/_editable_attribute.html.erb b/app/views/hotsheet/pages/_editable_attribute.html.erb
@@ -1,9 +1,9 @@
-<%# locals: (attribute:, record:) %>
+<%# locals: (attribute:, model:, record:) %>
 
 <%= turbo_frame_tag "#{dom_id record}-#{attribute}" do %>
   <div data-controller="editable-attribute"
       data-editable-attribute-broadcast-url-value="<%= broadcast_edit_intent_path %>"
-      data-editable-attribute-resource-name-value="<%= record.class.name.downcase %>"
+      data-editable-attribute-resource-name-value="<%= model.table_name %>"
       data-editable-attribute-resource-id-value="<%= record.id %>">
     <div class="readonly-attribute"
         data-editable-attribute-target="readonlyAttribute"
@@ -12,7 +12,7 @@
     </div>
 
     <div data-editable-attribute-target="attributeForm" style="display:none">
-      <%= form_for record do |f| %>
+      <%= form_for record, url: "#{root_path}#{model.table_name}/#{record.id}" do |f| %>
         <%= f.text_field attribute, class: "editable-input", data: {
           editable_attribute_target: "attributeFormInput",
           action: "keydown.enter->editable-attribute#submitForm blur->editable-attribute#submitForm"

diff --git a/app/views/hotsheet/pages/index.html.erb b/app/views/hotsheet/pages/index.html.erb
@@ -2,7 +2,7 @@
   <h1>Hotsheet</h1>
   <p>Welcome to the hottest sheet around. Select a model from the sidebar to view the spreadsheet.</p>
 <% else %>
-  <h1><%= @model %></h1>
+  <h1><%= @model.model_name.human %></h1>
   <table>
     <thead>
       <tr>
@@ -16,7 +16,7 @@
         <tr>
           <% @model.editable_attributes.each do |attribute| %>
             <td>
-              <%= render "editable_attribute", record: record, attribute: attribute %>
+              <%= render "editable_attribute", model: @model, record: record, attribute: attribute %>
             </td>
           <% end %>
         </tr>

diff --git a/app/views/layouts/hotsheet/_sidebar.html.erb b/app/views/layouts/hotsheet/_sidebar.html.erb
@@ -4,7 +4,7 @@
   <nav>
     <ul>
       <% Hotsheet.models.each do |model| %>
-        <%= link_to model.model_name.human, hotsheet_model_path(model) %>
+        <%= link_to model.model_name.human, "#{root_path}#{model.table_name}" %>
       <% end %>
     </ul>
   </nav>

diff --git a/config/initializers/hotsheet/editable_attributes.rb b/config/initializers/hotsheet/editable_attributes.rb
@@ -1,6 +1,9 @@
 # frozen_string_literal: true
 
 Rails.application.config.after_initialize do # rubocop:disable Metrics/BlockLength
+  # Only run this initializer when running the Rails server
+  next unless defined? Rails::Server
+
   Hotsheet.configuration.models.each_key do |model| # rubocop:disable Metrics/BlockLength
     model.constantize.class_eval do
       class << self