Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination #1

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Add pagination #1

merged 6 commits into from
Nov 5, 2024

Conversation

hunchr
Copy link
Member

@hunchr hunchr commented Nov 4, 2024

TICKET-22974

@hunchr hunchr self-assigned this Nov 4, 2024
@hunchr hunchr marked this pull request as ready for review November 4, 2024 09:44
@hunchr
Copy link
Member Author

hunchr commented Nov 4, 2024

tests will be added in another ticket

@hunchr hunchr requested a review from ignaciosy November 4, 2024 09:44
Copy link
Collaborator

@ignaciosy ignaciosy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! small remarks only

app/assets/stylesheets/hotsheet/pagy.css Outdated Show resolved Hide resolved
app/controllers/hotsheet/pages_controller.rb Outdated Show resolved Hide resolved
config/initializers/hotsheet/pagy.rb Outdated Show resolved Hide resolved
# Conflicts:
#	app/views/layouts/hotsheet/application.html.erb
@hunchr hunchr force-pushed the feature/22974-pagination branch from e2e3ae1 to 738d308 Compare November 5, 2024 06:56
@hunchr hunchr merged commit 886a83b into main Nov 5, 2024
1 check passed
@hunchr hunchr deleted the feature/22974-pagination branch November 5, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants