Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash messages layout #38

Merged
merged 7 commits into from
Feb 3, 2025
Merged

Flash messages layout #38

merged 7 commits into from
Feb 3, 2025

Conversation

ignaciosy
Copy link
Collaborator

@ignaciosy ignaciosy commented Jan 15, 2025

Closes #29 and is related to #15

image
Screen.Recording.2025-01-15.at.14.46.05.mov

Also defined some base css variables like colors, so we can adjust them easily in the future.

@ignaciosy ignaciosy self-assigned this Jan 15, 2025
@ignaciosy ignaciosy requested a review from a team as a code owner January 15, 2025 17:49
Copy link
Member

@simon-isler simon-isler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flash still appears above the heading?

app/views/layouts/hotsheet/_flash.html.erb Outdated Show resolved Hide resolved
app/assets/stylesheets/hotsheet/application.css Outdated Show resolved Hide resolved
app/controllers/hotsheet/pages_controller.rb Show resolved Hide resolved
@ignaciosy ignaciosy mentioned this pull request Jan 20, 2025
@ignaciosy ignaciosy changed the base branch from main to fix-ci-ruby-version January 20, 2025 09:41
@ignaciosy ignaciosy force-pushed the feature/flash-layout branch from 1247b96 to df62803 Compare January 20, 2025 09:42
@ignaciosy ignaciosy requested a review from a team January 22, 2025 13:36
@simon-isler simon-isler self-requested a review January 23, 2025 07:59
app/assets/stylesheets/hotsheet/application.css Outdated Show resolved Hide resolved
app/assets/stylesheets/hotsheet/application.css Outdated Show resolved Hide resolved
app/assets/stylesheets/hotsheet/application.css Outdated Show resolved Hide resolved
app/controllers/hotsheet/pages_controller.rb Show resolved Hide resolved
lib/hotsheet/version.rb Outdated Show resolved Hide resolved
Base automatically changed from fix-ci-ruby-version to main February 1, 2025 09:57
@ignaciosy ignaciosy force-pushed the feature/flash-layout branch from 696d067 to a5451f9 Compare February 3, 2025 13:25
@ignaciosy ignaciosy merged commit 4a480b4 into main Feb 3, 2025
7 checks passed
@ignaciosy ignaciosy deleted the feature/flash-layout branch February 3, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The flash layout is displayed behind the sidebar
2 participants