Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Screenshots function #138

Closed
wants to merge 2 commits into from

Conversation

owens-ben
Copy link

Hi @AmsterGet, here is the code I wrote to upload screenshots.

It works by looking for the directory of screenshots, then normalizing the failed test titles and matches them with the screenshot directory.

This was written to work specifically with my org's file structure so there will be several changes you'll need to implement to make it versatile enough for everyone.

You may also prefer to take a different approach by implementing another tempid value that would remove the need for string manipulation and probably be more resilient.

@owens-ben owens-ben requested a review from AmsterGet as a code owner March 4, 2024 15:49
@AmsterGet
Copy link
Member

Hi @owens-ben !
Thank you very much!
I'd also like to engage @AliakseiLiasnitski to review this PR, as he has been working on researching how to implement this feature.
Aliaksei will be back from vacation next week and we'll check your suggestions.

@AmsterGet
Copy link
Member

Related to #122

@owens-ben owens-ben closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants