fix: remove unused output to remove warning (#260)

reside-eng · May 3, 2023 · 4e71a4f · 4e71a4f
1 parent d195208
commit 4e71a4f
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 10 deletions.
diff --git a/action.yml b/action.yml
@@ -25,9 +25,6 @@ inputs:
   flag-name:
     description: 'Flag name'
     required: false
-outputs:
-  coveralls-url:
-    description: 'URL for Coveralls build'
 runs:
   using: 'node16'
   main: 'dist/index.js'

diff --git a/dist/index.js b/dist/index.js
@@ -20118,7 +20118,6 @@ const github_1 = __nccwpck_require__(5438);
 const coveralls_api_1 = __importDefault(__nccwpck_require__(6398));
 /**
  * Report coverage to Coveralls for base branch
- *
  * @param lcovPath - Path to lcov file
  */
 async function reportToCoveralls(lcovPath) {
@@ -20146,7 +20145,9 @@ async function reportToCoveralls(lcovPath) {
             throw new Error(response.message);
         }
         core.info(`Successfully uploaded base coverage to Coveralls for branch "${branch}". Coveralls URL: ${response?.url}`);
-        core.setOutput('coverage-url', response?.url);
+        // NOTE: Removed because @actions/core uses deprecated set output command internally
+        // See: https://github.com/actions/toolkit/issues/1336#issuecomment-1502056286
+        // core.setOutput('coverage-url', response?.url);
     }
     catch (err) {
         const error = err;

diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
     "@side/eslint-config-base": "1.0.0",
     "@side/eslint-config-jest": "1.0.0",
     "@side/prettier-config": "1.0.0",
-    "@side/semantic-config-base": "^0.0.1",
+    "@side/semantic-config-base": "0.0.1",
     "@tsconfig/node16": "1.0.3",
     "@types/jest": "29.5.1",
     "@types/node": "16.18.25",

diff --git a/src/coveralls.ts b/src/coveralls.ts
@@ -6,7 +6,6 @@ type ActualPostJobResponse = (PostJobResponse & { error: boolean }) | null;
 
 /**
  * Report coverage to Coveralls for base branch
- *
  * @param lcovPath - Path to lcov file
  */
 export async function reportToCoveralls(lcovPath: string) {
@@ -49,7 +48,9 @@ export async function reportToCoveralls(lcovPath: string) {
     core.info(
       `Successfully uploaded base coverage to Coveralls for branch "${branch}". Coveralls URL: ${response?.url}`,
     );
-    core.setOutput('coverage-url', response?.url);
+    // NOTE: Removed because @actions/core uses deprecated set output command internally
+    // See: https://github.com/actions/toolkit/issues/1336#issuecomment-1502056286
+    // core.setOutput('coverage-url', response?.url);
   } catch (err) {
     const error = err as Error;
     core.error(`Error uploading lcov to Coveralls: ${error.message}`);

diff --git a/yarn.lock b/yarn.lock
@@ -1264,7 +1264,7 @@ __metadata:
     "@side/eslint-config-base": 1.0.0
     "@side/eslint-config-jest": 1.0.0
     "@side/prettier-config": 1.0.0
-    "@side/semantic-config-base": ^0.0.1
+    "@side/semantic-config-base": 0.0.1
     "@tsconfig/node16": 1.0.3
     "@types/jest": 29.5.1
     "@types/node": 16.18.25
@@ -1358,7 +1358,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@side/semantic-config-base@npm:^0.0.1":
+"@side/semantic-config-base@npm:0.0.1":
   version: 0.0.1
   resolution: "@side/semantic-config-base@npm:0.0.1"
   dependencies: