Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RecommendedWatcher instead of INotifyWatcher #2481

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Use RecommendedWatcher instead of INotifyWatcher #2481

merged 1 commit into from
Jan 10, 2025
+2 −2

Conversation

muhamadazmy
Copy link
Contributor

Use RecommendedWatcher instead of INotifyWatcher

Summary:
Fixes issue on MacOS

AhmedSoliman
AhmedSoliman approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@AhmedSoliman AhmedSoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's merge after GHA is green.

@muhamadazmy muhamadazmy merged commit ac735ac into restatedev:main Jan 10, 2025
12 checks passed
@muhamadazmy muhamadazmy deleted the pr2481 branch January 10, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedSoliman AhmedSoliman AhmedSoliman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muhamadazmy @AhmedSoliman