Flush local filesystem snapshot IO #2483
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcholakov
force-pushed
the
fix/snapshot-local-fs-failures
branch
from
01c7c91 to
d92d5cd
Compare
pcholakov
changed the title
pcholakov
commented
Jan 10, 2025
| let mut snapshot_file = | ||
| tokio::fs::File::create_new(&file_path).await.map_err(|e| { | ||
| anyhow!("Failed to create snapshot file {:?}: {}", file_path, e) | ||
| })?; | ||
| let size = io::copy(&mut file_data, &mut snapshot_file) | ||
| .await | ||
| .map_err(|e| anyhow!("Failed to download snapshot file {:?}: {}", key, e))?; | ||
| snapshot_file.shutdown().await?; |
There was a problem hiding this comment.
This might have been a production bug that could have caused files to be truncated on download! Thanks for catching this, @muhamadazmy 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C/f #2428