Add better support for rust-like number literals #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: max <gmx.sht@gmail.com>
Signed-off-by: max <gmx.sht@gmail.com>
PizzasBear
changed the title
djc
reviewed
Nov 20, 2023
askama_parser/src/lib.rs
Outdated
| @@ -252,8 +251,88 @@ fn bool_lit(i: &str) -> ParseResult<'_> { | |||
| fn num_lit(i: &str) -> ParseResult<'_> { | |||
| recognize(tuple(( | |||
| opt(char('-')), | |||
| digit1, | |||
| opt(pair(char('.'), digit1)), | |||
| // digit1, | |||
There was a problem hiding this comment.
Looks like there's a bunch of duplication here, which I'd like to avoid. I'm guessing this will require some named parsers, which would probably aid in making this code easier to understand. Also please remove the commented out version of the old code.
Signed-off-by: max <gmx.sht@gmail.com>
|
I've tried to reduce the duplication, and removed the commented-out code. |
Signed-off-by: max <gmx.sht@gmail.com>
Signed-off-by: max <gmx.sht@gmail.com>
djc
approved these changes
Nov 22, 2023
Signed-off-by: max <gmx.sht@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for underscore separators, scientific notation and suffixes (e.g.
usizeorf64) for numbers.Alleviates issue #882 for number literals.