Implement baseline int8 kernel for WASM #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for downstream libraries wanting to use operations on these types that are not available in rten-simd's traits.
This initial implementation performs about the same as f32 or slightly slower. Faster kernels should be possible via one of: - Upconverting to i16 during packing and using `i32x4_dot_i16x8` - Using `i32x4.dot_i8x16_i7x16_add_s` if the `relaxed-simd` target feature is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial implementation performs about the same as f32 or slightly slower.
Faster kernels should be possible via one of:
i32x4_dot_i16x8i32x4.dot_i8x16_i7x16_add_sif therelaxed-simdtarget feature isenabled