fix: oxc esbuild transform option compat

rolldown · Jan 10, 2025 · a104db3 · a104db3
1 parent 2814e17
commit a104db3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts
@@ -57,6 +57,7 @@ import {
   mergeWithDefaults,
   normalizePath,
   partialEncodeURIPath,
+  unique,
 } from './utils'
 import { perEnvironmentPlugin, resolveEnvironmentPlugins } from './plugin'
 import { manifestPlugin } from './plugins/manifest'
@@ -434,6 +435,11 @@ export function resolveBuildEnvironmentOptions(
   if (merged.target === 'modules') {
     merged.target = ESBUILD_MODULES_TARGET
   }
+  // dedupe target
+  if (Array.isArray(merged.target)) {
+    // esbuild allowed duplicate targets but oxc does not
+    merged.target = unique(merged.target)
+  }
 
   // normalize false string into actual false
   if ((merged.minify as string) === 'false') {

diff --git a/packages/vite/src/node/plugins/oxc.ts b/packages/vite/src/node/plugins/oxc.ts
@@ -190,7 +190,7 @@ export async function transformWithOxc(
           const esTargetIndex = target.findIndex((t) =>
             t.toLowerCase().startsWith('es'),
           )
-          if (esTargetIndex > 0) {
+          if (esTargetIndex >= 0) {
             const esTargetTrimmed = target[esTargetIndex].toLowerCase().slice(2)
             if (
               esTargetTrimmed === 'next' ||