Remove pico_i2c_pio example #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two reasons: - it depends on an unreleased version of i2c-pico - i2c-pico depends on rp2040-hal = "0.6.0" The latter causes a circular dependency between the git repos rp-hal and i2c-pico. This makes updating version numbers more difficult: It requires incremental updates, first updating the version of rp2040-hal, then updating i2c-pico to use the newer hal version, and only then updating the board support crates and their examples. This could be reconsidered once we move the BSPs into separate repositories, rp-rs#244.
|
I'm in favour of this. It can always come back later. |
ithinuel
approved these changes
Dec 10, 2022
Correct! I had a quick look at the repo, but didn't notice the open PR. rp-rs/i2c-pio-rs#6 |
|
This would be superseded by #517 in case the BSP move gets approved. |
|
#517 was merged, so this PR is obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two reasons:
The latter causes a circular dependency between the git repos rp-hal and i2c-pico. This makes updating version numbers more difficult: It requires incremental updates, first updating the version of rp2040-hal, then updating i2c-pico to use the newer hal version, and only then updating the board support crates and their examples.
This could be reconsidered once we move the BSPs into separate repositories, #244.