Merge bootc branch to master
#2180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support automatic builds on git commits. Used to generate up to date RPMs of dnf for testing and development purposes.
Text alignment and formatting in the spec file.
Adds support for the --transient option on all transactions. Passing --transient on a bootc system will call `bootc usr-overlay` to create a transient writeable /usr and continue the transaction. Specifying --transient on a non-bootc system will throw an error; we don't want to mislead users to thinking this feature works on non-bootc systems. If --transient is not specified and the bootc system is in a locked state, the operation will be aborted and a message will be printed suggesting to try again with --transient.
|
#2186 should be merged first. |
evan-goode
added a commit
to evan-goode/ci-dnf-stack
that referenced
this pull request
Jan 15, 2025
The --transient flag only works on a bootc system, but we should test that it throws the correct error and doesn't do anything unexpected on non-bootc systems. Requires rpm-software-management/dnf#2180 and rpm-software-management/libdnf#1683.
evan-goode
added a commit
to rpm-software-management/ci-dnf-stack
that referenced
this pull request
Jan 15, 2025
The --transient flag only works on a bootc system, but we should test that it throws the correct error and doesn't do anything unexpected on non-bootc systems. Requires rpm-software-management/dnf#2180 and rpm-software-management/libdnf#1683.
Documents the new `--transient` command-line argument and `persistence` configuration option. I tried to use a table for listing the valid options for `persistence`, but RST does not automatically wrap table cells containing long lines, so a list was much easier.
Using libostree gives us more detail about the current state of the deployment than only checking whether /usr is writable.
To keep /usr read-only after DNF is finished with a transient transaction, we call `ostree admin unlock --transient` to mount the /usr overlay as read-only by default. Then, we create a private mount namespace for DNF and its child processes and remount the /usr overlayfs as read/write in the private mountns. os.unshare is unfortunately only available in Python >= 3.12, so we have to call libc.unshare via Python ctypes here and hardcode the CLONE_NEWNS flag that we need to pass.
|
For testing this, you'll need to do the following broad steps:
podman-bootc is the recommended way to do all this, but from my experience it can be a little unreliable. I personally use these scripts based on bootc-image-builder and virt-install. |
dnf-bootc's only job is to Require python3-gobject-base and ostree-libs, which are needed to check the unlock status on bootc systems. We don't want to add these dependencies on `python3-dnf` because we don't want them on non-bootc systems, so we use a subpackage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, along with rpm-software-management/libdnf#1683, merges support for the
--transientflag and thepersistence=auto|persist|transientconfiguration option for https://issues.redhat.com/browse/RHEL-70917. See also #2155.Also included are some build files for Copr that may be useful for future feature branches similar to
bootc.Merging this PR doesn't mean that work on the
--transientfeature is 100% done, just that we're confident enough we're not going to totally scrap it and we want to continue its development on themasterbranch.