Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-install blog post by guest author Ngan Pham #190

Merged
merged 1 commit into from
May 30, 2024
Merged

Auto-install blog post by guest author Ngan Pham #190

merged 1 commit into from
May 30, 2024

Conversation

martinemde
Copy link
Member

@martinemde martinemde commented May 30, 2024 •
edited
Loading

After a rave review of rubygems/rubygems#6561 by Ngan Pham, I asked if they were interested in writing a blog post and this is it!

Thanks Ngan!

ngan
ngan reviewed May 30, 2024
View reviewed changes
Copy link

@ngan ngan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 looks good!

@martinemde martinemde force-pushed the martinemde/add-post-by-ngan-pham branch from 68aac49 to 66e6f6f Compare May 30, 2024 00:44
deivid-rodriguez
deivid-rodriguez approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a grammar fix, but I'm not sure it's even correct 🤔.

Other than that, this is awesome! Thanks so much for telling your story and for the work and patience to land the improvement 😃

_posts/2024-05-29-bundler-auto-install-just-got-a-whole-lot-better.md Outdated Show resolved Hide resolved
@martinemde martinemde force-pushed the martinemde/add-post-by-ngan-pham branch from 66e6f6f to f4cd113 Compare May 30, 2024 16:53
@martinemde
Add post about auto-install by Ngan Pham
8e16c09 
Signed-off-by: Martin Emde <me@martinemde.com>
@martinemde martinemde force-pushed the martinemde/add-post-by-ngan-pham branch from f4cd113 to 8e16c09 Compare May 30, 2024 16:54
@martinemde martinemde merged commit 703ff00 into master May 30, 2024
2 checks passed
@martinemde martinemde deleted the martinemde/add-post-by-ngan-pham branch May 30, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simi simi simi left review comments

@ngan ngan ngan left review comments

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

@indirect indirect indirect approved these changes

@segiddins segiddins Awaiting requested review from segiddins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinemde @indirect @ngan @simi @deivid-rodriguez