-
-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glutin version 0.32.2 #1722
Merged
Merged
Glutin version 0.32.2 #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow making the context not current by reference.
We can not do anything about the gl_generator at this point, so just continue disabling things clippy don't really like.
This follows the EGL api to make surfaceless platforms.
This follows the EGL api to make surfaceless platforms.
This follows the EGL api to make surfaceless platforms.
Some EGL drivers report the KHR extension with EGL 1.4, which doesn't make any sense, however given that the constant for MESA and KHR is the same, we can check for KHR in MESA branch, but still use the Ext functions. Fixes rust-windowing#1708.
Add `GlContext::priority` and `ContextAttributesBuilder::with_priority` to get and set context priority respectively. Fixes rust-windowing#1694. Fixes rust-windowing#1645. Co-authored-by: Kirill Chibisov <contact@kchibisov.com>
MarijnS95
reviewed
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see any weird/breaking changes from picking, looks good.
Awh unfortuntely this PR/commit title wasn't updated to reflect massively changed contents :/
In general, you can raise those style changes against master, but I can not solve them here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.