Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rudimentary decoding for stake txs #3445

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

compojoom
Copy link
Collaborator

Instead of showing “unknown operation” we now display the type of stake tx.
Without this any stake TXs are shown as unkown operations:
grafik
grafik

With the changes stake txs are shown as follows:
grafik
simulator_screenshot_1C36DE66-02F0-4839-BC77-956B4BD23AB0
simulator_screenshot_4030DAD2-8EC0-4351-A520-668B6FECA92E

Changes proposed in this pull request:

Instead of showing “unknown operation” we now display the type of stake
tx.
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (bb1554a) to head (0252425).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #3445       +/-   ##
==========================================
+ Coverage   8.10%   95.11%   +87.00%     
==========================================
  Files        796       29      -767     
  Lines      45050     1452    -43598     
==========================================
- Hits        3650     1381     -2269     
+ Misses     41400       71    -41329     
Flag Coverage Δ
95.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compojoom compojoom merged commit 86a076a into main Sep 30, 2024
4 checks passed
@compojoom compojoom deleted the feat-add-decoding-staking-tx branch September 30, 2024 11:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants