Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update once_cell #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update once_cell #7

wants to merge 1 commit into from

Conversation

sigaloid
Copy link

Update the dependency specified. Fixes error when using with criterion. Passes tests

$> cargo add threadfin
    Updating crates.io index
      Adding threadfin v0.1.2 to dependencies.
    Updating crates.io index
error: failed to select a version for `once_cell`.
    ... required by package `threadfin v0.1.2`
    ... which satisfies dependency `threadfin = "^0.1.2"` of package `package v0.1.0`
versions that meet the requirements `>=1.0, <=1.14` are: 1.14.0, 1.13.1, 1.13.0, 1.12.1, 1.12.0, 1.11.0, 1.10.0, 1.9.0, 1.8.0, 1.7.2, 1.7.1, 1.7.0, 1.6.0, 1.5.2, 1.5.1, 1.4.1, 1.4.0, 1.3.1, 1.3.0, 1.2.0, 1.1.0, 1.0.2, 1.0.1

all possible versions conflict with previously selected packages.

  previously selected package `once_cell v1.17.1`
    ... which satisfies dependency `once_cell = "^1.14"` of package `criterion v0.5.1`
    ... which satisfies dependency `criterion = "^0.5.1"` of package `package v0.1.0`

failed to select a version for `once_cell` which could resolve this conflict

Branch use_std on my fork also uses the new std equivalents from 1.70.0 and gets rid of the dependence on once_cell, whenever you would be okay with bumping the msrv.

@sagebind
Copy link
Owner

This already requires a bump to MSRV since once_cell 1.15+ does not compile under Rust 1.51 last I checked, which is why the version range was specified that way. But we probably can bump the MSRV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants